[WC-3464] Rich text Tiptapeditor#2270
Open
gjulivan wants to merge 3 commits into
Open
Conversation
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
2 times, most recently
from
July 1, 2026 08:34
584fe21 to
96df6fb
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
from
July 1, 2026 08:53
96df6fb to
57a6695
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
from
July 2, 2026 21:56
57a6695 to
3ca1f8c
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
8 times, most recently
from
July 13, 2026 00:08
32f038c to
e544a1d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
from
July 13, 2026 20:17
c4bbd17 to
6397d1b
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
Would have a look at the high and medium flagged CC review comments |
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
4 times, most recently
from
July 21, 2026 11:15
f7d16ca to
2755b5d
Compare
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
3 times, most recently
from
July 24, 2026 10:58
5925c7a to
bd5d88b
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
from
July 24, 2026 11:24
bd5d88b to
6d6c750
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
from
July 24, 2026 11:49
6d6c750 to
cd882a6
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
from
July 24, 2026 12:28
cd882a6 to
9bf1d12
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
2 times, most recently
from
July 24, 2026 17:10
469eaa6 to
aa56ad2
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
3 times, most recently
from
July 27, 2026 09:07
87a4a10 to
8853e96
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
4 times, most recently
from
July 27, 2026 12:54
fbf5d78 to
f12a929
Compare
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
2 times, most recently
from
July 27, 2026 12:57
5da8c04 to
844971a
Compare
gjulivan
force-pushed
the
rich-text/tiptapeditor
branch
from
July 27, 2026 13:58
844971a to
e97de41
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // Blur the editor to trigger the save/normalize path. | ||
| await page.keyboard.press("Tab"); | ||
| await page.waitForTimeout(500); |
Contributor
There was a problem hiding this comment.
🔶 Medium — Hardcoded waitForTimeout delay
page.waitForTimeout(500) is a hardcoded sleep. Per e2e-test-guidelines, replace it with a web-first assertion that resolves as soon as the condition is met.
After pressing Tab to blur, the editor's empty-content normalisation is synchronous within Tiptap's state flush. A reliable wait is:
Suggested change
| await page.waitForTimeout(500); | |
| await expect(editor).toHaveAttribute("data-placeholder"); |
Or, if you want to assert the save has propagated to the Mendix attribute, wait for the text-content assertion itself (Playwright retries automatically):
await page.keyboard.press("Tab");
await expect(editor).toContainText("");Either avoids the 500 ms wall-clock cost and the flakiness risk of a fixed sleep.
| await page.goto("/p/classmode"); | ||
| await waitForMendixApp(page); | ||
| await expect(page.locator(".mx-name-richText1")).toBeVisible(); | ||
| await expect(page.locator(".mx-name-richText1")).toHaveScreenshot(`classModeEditor.png`, { threshold: 0.4 }); |
Contributor
There was a problem hiding this comment.
🔶 Medium — Missing screenshot baselines for new class-mode tests
classModeEditor.png and classModeViewCodeDialog.png (line 170) are referenced by toHaveScreenshot but their baseline PNGs are not committed to the snapshots directory. Playwright will fail on first run because there is nothing to compare against.
Per the E2E guidelines, baseline images must be committed with the spec. Generate and commit them before merging:
cd packages/pluggableWidgets/rich-text-web
pnpm run e2e --update-snapshots
git add e2e/RichText.spec.js-snapshots/classModeEditor-chromium-linux.png \
e2e/RichText.spec.js-snapshots/classModeViewCodeDialog-chromium-linux.png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Description